Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: isEncrypted breaks volume page #1256

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Jan 3, 2025

Summary

fix: isEncrypted() breaks the volume page.

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?

Related Issue #
harvester/harvester#7150

Reproduce step

kubectl apply -f fake-pv.yaml

apiVersion: v1
kind: PersistentVolume
metadata:
  name: fake-pv
spec:
  accessModes:
  - ReadWriteMany
  capacity:
    storage: 10Gi
  claimRef:
    apiVersion: v1
    kind: PersistentVolumeClaim
    name: fake-pvc
    namespace: default
  volumeMode: Block
  local:
    path: /tmp/foo
  nodeAffinity:
    required:
      nodeSelectorTerms:
        - matchExpressions:
          - key: kubernetes.io/hostname
            operator: In
            values:
            - fake-node-name
---
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: fake-pvc
spec:
  accessModes:
  - ReadWriteMany
  resources:
    requests:
      storage: 10Gi
  volumeMode: Block
  volumeName: fake-pv

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Before fix
Screenshot 2025-01-09 at 3 07 04 PM

After fix

image

@a110605 a110605 requested review from torchiaf and houhoucoop January 3, 2025 05:45
@a110605 a110605 self-assigned this Jan 3, 2025
@torchiaf
Copy link
Collaborator

torchiaf commented Jan 3, 2025

Did you check if there are places where missing this.relatedPV breaks the UI ? Otherwise LGTM

@a110605 a110605 marked this pull request as ready for review January 6, 2025 06:17
@a110605 a110605 requested a review from Vicente-Cheng January 6, 2025 06:18
@a110605 a110605 changed the title fix: isEncrypted breaks all volume page (under testing) fix: isEncrypted breaks volume page Jan 6, 2025
@a110605 a110605 changed the title fix: isEncrypted breaks volume page fix: isEncrypted breaks volume page (DO_NOT_MERGED) Jan 6, 2025
Copy link

@Vicente-Cheng Vicente-Cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@a110605 a110605 changed the title fix: isEncrypted breaks volume page (DO_NOT_MERGED) fix: isEncrypted breaks volume page Jan 9, 2025
@a110605 a110605 merged commit 1c55c2e into harvester:master Jan 9, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants