fix: missing vnc reconnecting label #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houhoucoop
added
Require backport v1.3
a110605
approved these changes
Jan 7, 2025
houhoucoop
force-pushed
the
fix/issue-7182
branch
from
d1ea413 to
18889c7
Compare
Signed-off-by: Yi-Ya Chen <[email protected]>
houhoucoop
force-pushed
the
fix/issue-7182
branch
from
18889c7 to
8b8a155
Compare
3 tasks
3 tasks
houhoucoop
added a commit
that referenced
this pull request
Jan 10, 2025
…v1.4/pr-1257 fix: missing vnc reconnecting label (backport #1257)
houhoucoop
added a commit
that referenced
this pull request
Jan 10, 2025
…v1.3/pr-1257 fix: missing vnc reconnecting label (backport #1257)
This was referenced Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
vncConsole.reconnecting.messagelabel is missingPR Checklist
Related Issue #
[BUG] [UI] Missing vnc reconnecting label #7182
Occurred changes and/or fixed issues
The label is missing from the shell/assets/translations/en-us.yaml in Rancher version 2.9 and lower.
Ref: https://github.com/rancher/dashboard/blob/release-2.9/shell/assets/translations/en-us.yaml#L7757-L7759.
Add translation key to
pkg/harvester/l10n/en-us.yamlto fix the issue.Technical notes summary
Add translation key to
pkg/harvester/l10n/en-us.yamlto fix the issue.Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video