Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove the check-plugins CI pipeline #1258

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

houhoucoop
Copy link

@houhoucoop houhoucoop commented Jan 8, 2025

Summary

CI Validate Plugin build system failures during yarn install

error @aws-sdk/[email protected]: The engine "node" is incompatible with this module. Expected version ">=18.0.0". Got "16.20.2"

Ref: https://github.com/harvester/dashboard/actions/runs/12647471727/job/35243644923?pr=1257#step:4:397

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue #

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

@houhoucoop houhoucoop self-assigned this Jan 8, 2025
@houhoucoop houhoucoop force-pushed the fix-ci-validate-failed branch from 24a3276 to 296e4fc Compare January 8, 2025 01:50
Signed-off-by: Yi-Ya Chen <[email protected]>
@houhoucoop houhoucoop force-pushed the fix-ci-validate-failed branch from 296e4fc to 4ca7cf4 Compare January 8, 2025 02:00
@houhoucoop houhoucoop requested review from a110605 and torchiaf January 8, 2025 02:08
@a110605
Copy link
Collaborator

a110605 commented Jan 8, 2025

Is it not work to use node 18 in

?

@houhoucoop
Copy link
Author

Is it not work to use node 18 in

?

Would it be better to use the same node version as the project?
The dashboard doesn't work with node 18.

@a110605
Copy link
Collaborator

a110605 commented Jan 8, 2025

As discussion, let's remove github/workflows/check-plugins.yaml .

@houhoucoop
Copy link
Author

As discussion, let's remove github/workflows/check-plugins.yaml .

Update in commit bd6577c.

@houhoucoop houhoucoop changed the title chore: add @aws-sdk resolutions to resolve CI failures chore: remove the check-plugins CI pipeline Jan 9, 2025
@a110605 a110605 merged commit 6bcc152 into harvester:master Jan 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants