Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use gh to release #66

Merged
merged 1 commit into from
Dec 19, 2024
Merged

feat: use gh to release #66

merged 1 commit into from
Dec 19, 2024

Conversation

Yu-Jack
Copy link
Contributor

@Yu-Jack Yu-Jack commented Dec 18, 2024

No description provided.

@Yu-Jack Yu-Jack self-assigned this Dec 18, 2024
@Yu-Jack Yu-Jack requested a review from bk201 December 18, 2024 07:49
files: ${{ steps.info.outputs.artifacts_dir }}/*
GH_TOKEN: ${{ github.token }}
run: |
gh release upload ${{ github.ref_name }} ${{ steps.info.outputs.artifacts_dir }}/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make it a prerelease to align with the original code?

Copy link
Contributor Author

@Yu-Jack Yu-Jack Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need to do it. It only uploads tarball when we create a release like this test https://github.com/Yu-Jack/docker-machine-driver-harvester/releases.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FrankYang0529 do we need prerelease set to true?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of previous releases were created by github-actions. Probably, it's better to create a draft release first and manually change to latest release.

Screenshot 2024-12-18 at 4 03 11 PM

Copy link
Contributor Author

@Yu-Jack Yu-Jack Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on tag or release. If we prefer to create a tag first, then we can use draft release. If we prefer to create a release directly, then we don't need to use this action to create a draft release. But, I just modified my codes to support creating a draft release.

Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@Yu-Jack Yu-Jack force-pushed the HARV/60 branch 2 times, most recently from 6a20dee to 9e31d5e Compare December 19, 2024 01:44
@Yu-Jack Yu-Jack merged commit ec01779 into harvester:master Dec 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants