-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use gh to release #66
Conversation
files: ${{ steps.info.outputs.artifacts_dir }}/* | ||
GH_TOKEN: ${{ github.token }} | ||
run: | | ||
gh release upload ${{ github.ref_name }} ${{ steps.info.outputs.artifacts_dir }}/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make it a prerelease to align with the original code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need to do it. It only uploads tarball when we create a release like this test https://github.com/Yu-Jack/docker-machine-driver-harvester/releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FrankYang0529 do we need prerelease set to true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends on tag or release. If we prefer to create a tag first, then we can use draft release. If we prefer to create a release directly, then we don't need to use this action to create a draft release. But, I just modified my codes to support creating a draft release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
6a20dee
to
9e31d5e
Compare
Signed-off-by: Jack Yu <[email protected]>
No description provided.