fix: ensure the machineset label value is valid per K8s convention #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It uses fnv-1a to generate a non-zero, non-cryptographic hash to replace any invalid characters in the label value. Since the machineset label value is only used to establish pod affinity, the actual label value is considered opaque. Ref: https://github.com/kubernetes-sigs/cluster-api/blob/010af7f92f98ead971742d347d258a8786d5d57c/util/labels/format/helpers.go Signed-off-by: Ivan Sim <[email protected]>
|
@ibrokethecloud Let me know what you think of this. My first thought is to delete those default affinity/anti-affinity rules, to make it easier to reason about and avoid unintended side effects. E.g., I am not sure why we append the affinity term to both the affinity and anti-affinity sets. Won't the affinity always take precedence, given the order they are evaluated? Or AIUI, it might make sense to keep the pod anti-affinity across nodes based on the original PR's intention. Or if we need to keep them, this PR proposes a solution based on what CAPI has done to tackle the same issue. PTAL. |
ibrokethecloud
approved these changes
Jan 30, 2025
|
Related issue: harvester/harvester#7467 |
FrankYang0529
approved these changes
Feb 3, 2025
|
@bk201 @ibrokethecloud let me know what the backport targets are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user defined custom affinity/anti-affinity rules for VMs, additional
preferredaffinity/anti-affinity rules are added to ensure thevirt-launcherpods don't land on the same node (by keying the rules off the node's hostname). Currently, there are no checks to ensure the generated label value in these rules adhered to the Kubernetes' labeling convention.This PR uses the same approach as CAPI to format and hash the label value. Since the machineset label value is only used to establish pod affinity, the actual (hashed or not) label value used is opaque.
EDIT: Issue at harvester/harvester#7467.