Merge pull request #20 from tserong/wip-fix-6484

fix: ensure dbus connections are closed in (Try)RestartService
harvester · Sep 3, 2024 · 9576346 · 9576346
2 parents 198df47 + 11ea70b
commit 9576346
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/sys/systemd-dbus.go b/sys/systemd-dbus.go
@@ -15,6 +15,7 @@ func RestartService(unit string) error {
 		logrus.Errorf("Failed to create new connection for systemd. err: %v", err)
 		return err
 	}
+	defer conn.Close()
 	responseChan := make(chan string, 1)
 	if _, err := conn.RestartUnitContext(ctx, unit, "fail", responseChan); err != nil {
 		logrus.Errorf("Failed to restart service %s. err: %v", unit, err)
@@ -32,6 +33,7 @@ func TryRestartService(unit string) error {
 		logrus.Errorf("Failed to create new connection for systemd. err: %v", err)
 		return err
 	}
+	defer conn.Close()
 	responseChan := make(chan string, 1)
 	if _, err := conn.TryRestartUnitContext(ctx, unit, "fail", responseChan); err != nil {
 		logrus.Errorf("Failed to restart service %s. err: %v", unit, err)