feat: add version library #12
Conversation
starbops
force-pushed
the
enh-2877
branch
4 times, most recently
from
bfcd6e3 to
a2fcc7a
Compare
| // Upgrading to dev versions is always allowed | ||
| if u.upgradeVersion.isDev { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
If "strictMode=true", we can still upgrade from one dev version to another dev version. It's a bit weird to me due to the word "strict", but if we are doing this for specific purpose, please ignore this comment.
There was a problem hiding this comment.
This is open to discussion. From a developer perspective, I tend to allow this kind of upgrade path (dev-to-dev upgrades) by default for the convenience of both developers and QA—actually, the part that leverages this library never bothers setting the strict mode off. It just checks the skip-check annotation and skip through the entire eligibility check, making the mode seem redundant. cc @bk201
There was a problem hiding this comment.
After discussion, the strict-mode for upgrade will be introduced as a new Harvester setting. I'll create a new ticket to track the progress. Thanks!
starbops
force-pushed
the
enh-2877
branch
2 times, most recently
from
5dca299 to
7eac1e2
Compare
| return nil | ||
| } | ||
|
|
||
| // Same-version upgrade is always allowed |
There was a problem hiding this comment.
Do we prohibit this in the current upgrade code?
There was a problem hiding this comment.
As I know, no. Why the ask?
The Harvester Version library augments the widelyused SemVer package, adding Harvester-specific logic, especially for Harvester upgrades. It is meant to be consumed by the Harvester controller and command-line helper tool. Signed-off-by: Zespre Chang <[email protected]>
The Harvester Version library augments the widelyused SemVer package, adding Harvester-specific logic, especially for Harvester upgrades. It is meant to be consumed by the Harvester controller and command-line helper tool.
Related issue: harvester/harvester#2877