manager: should not use calico mac address to check the node #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We depend on the system interface to ensure the node ID, but the
calico MAC address `ee:ee:ee:ee:ee:ee` is the special MAC address
that each guest cluster might have. So, we should not use it to
check the node id.
Signed-off-by: Vicente Cheng <[email protected]>
bk201
approved these changes
Nov 12, 2024
WebberHuang1118
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:
The Harvester CSI driver used the wrong node ID, which caused the volume to attach to the wrong node.
Then, every workload that depends on that volume will hang.
Solution:
Do not use the Calico mac address to check the node.
Related Issue:
harvester/harvester#6981
Test plan: