Skip to content

Commit

Permalink
get rid of some comments
Browse files Browse the repository at this point in the history
Signed-off-by: Tim Serong <[email protected]>
  • Loading branch information
tserong committed May 22, 2024
1 parent dc775c0 commit 91b757e
Showing 1 changed file with 4 additions and 10 deletions.
14 changes: 4 additions & 10 deletions scripts/lib/image
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,11 @@ pull_images() {
local repository

if [ -z "$USE_LOCAL_IMAGES" ]; then
# this rotten thing exits with
# time="2024-05-22T10:50:00Z" level=fatal msg="exit status 123"
# if _any_ invocation of the command fails! so we have no way to
# know which invocation ruined it for all of us...
#xargs -n1 -t docker image pull < $image_list
# ...we'll (hopefully) get a better idea if we do this in a loop....
# Doing this in a loop rather than using `xargs` means if any individual
# image fails to pull, we bail out immediately and can see which image
# caused the problem.
for image in $(cat $image_list); do
docker pull $image
docker image pull --quiet $image
done
return
fi
Expand Down Expand Up @@ -94,11 +91,8 @@ save_image()

local archive_name="$(basename ${image_list%.txt}).tar"
local archive_file="${save_dir}/${archive_name}"
echo "tserong: pulling images"
pull_images $image_list
echo "tserong: images pulled, saving images"
docker image save -o $archive_file $(<${image_list})
echo "tserong: images saved, compressing"
zstd --rm $archive_file

add_image_list_to_metadata $image_type $bundle_dir $image_list "${archive_file}.zst"
Expand Down

0 comments on commit 91b757e

Please sign in to comment.