ci: migrate .drone.yml to github build action #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tserong
force-pushed
the
wip-ci-github-actions
branch
2 times, most recently
from
7f8a77d to
5b95b78
Compare
tserong
force-pushed
the
wip-ci-github-actions
branch
from
5b95b78 to
7903f02
Compare
tserong
changed the title
tserong
changed the title
tserong
force-pushed
the
wip-ci-github-actions
branch
2 times, most recently
from
927dc31 to
4e5ef24
Compare
tserong
force-pushed
the
wip-ci-github-actions
branch
13 times, most recently
from
77b76aa to
edfac50
Compare
tserong
force-pushed
the
wip-ci-github-actions
branch
6 times, most recently
from
09d5b00 to
ed14dd0
Compare
This gives us amd64 and arm64 ISO builds on every pull request and also on branch pushes of master and v*. ISO images are saved with the workflow as artifact ZIP files in case they are useful for manual testing. Unlike with the Drone build, we are _not_ publishing images to releases.rancher.com to avoid potential collisions with images published from the main harvester repo. Signed-off-by: Tim Serong <[email protected]>
Using `xargs -n1 -t docker image pull --quiet < $image_list` means that if any individual image fails to pull, `xargs` exits with failure, but we don't know which image actually failed to pull. If we instead use a loop, we bail out immediately and can see which image pull caused the problem. Signed-off-by: Tim Serong <[email protected]>
tserong
force-pushed
the
wip-ci-github-actions
branch
from
ed14dd0 to
6ed5ca5
Compare
While the ISO artifacts may theoretically be useful for manually testing PRs, they are quite large... Given it's easy enough to build ISOs manually locally for testing, let's just stick with that and not use so many resources :-) Signed-off-by: Tim Serong <[email protected]>
|
@Mergifyio backport v1.2 v1.3 |
✅ Backports have been created
|
This was referenced May 30, 2024
This was referenced May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Need to migrate from Drone to Github Actions
Solution:
This gives us amd64 and arm64 ISO builds on every pull request and also on branch pushes of master and v*.
ISO images are saved with the workflow as artifact ZIP files in case they are useful for manual testing.Unlike with the Drone build, we are not publishing images to releases.rancher.com to avoid potential collisions with images published from the main harvester repo.This PR also makes a small change to
scripts/lib/imageto make it easier to debug image pull failures during build.Related Issue:
harvester/harvester#5327