feat: Show DNS Servers on Confirm Install Panel #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* if the user inputs DNS servers during the interactive ISO install they are then going to be shown during the confirm install panel Resolves: feat/confirm-install-panel-show-dns-servers See also: harvester/harvester#5696
bk201
requested review from
tserong,
Vicente-Cheng and
mingshuoqiu
and removed request for
tserong
Vicente-Cheng
approved these changes
Apr 30, 2024
|
@Mergifyio backport v1.3 v1.2 |
✅ Backports have been created
|
This was referenced May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: feat/confirm-install-panel-show-dns-servers
See also: harvester/harvester#5696
Problem:
Show the DNS Servers the user input from the interactive iso install on the confirm installation panel
Solution:
When the User is inputing DNS servers in the field seperated by comma on the interactive ISO install, currently, the user "cannot" see those input DNS servers on the final step of the interactive ISO install on the confirm installation panel. This allows the user to see those DNS servers they input. If the user did not input anything in the DNS Server section, the DNS servers will not be shown.
Related Issue:
harvester/harvester#5696
Test plan:
Path A:
Path B:
dns servers: A.B.C.D,E.F.G.Hetc. on the final confirm installtion panel, as it will be left blank entirelyCross Ref Photos: