Log validateConfig, PrepareWebooks and doInstall errors (backport #775) #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Prior to this commit, errors returned from the above functions would be printed to the console, but not logged. This meant that if you weren't able to access the console for whatever reason, but _could_ access the log file, you would have no idea what went wrong if one of those function calls failed. Related issue: harvester/harvester#6214 Signed-off-by: Tim Serong <[email protected]> (cherry picked from commit 5ffebed)
Vicente-Cheng
approved these changes
Jul 24, 2024
bk201
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Prior to this commit, errors returned from
validateConfig(),PrepareWebooks()anddoInstall()would be printed to the console, but not logged. This meant that if you weren't able to access the console for whatever reason, but could access the log file, you would have no idea what went wrong if one of those function calls failed.Solution:
Call
logrus.Error()in addition toprintToPanel().Bonus: call
logrus.Info("Installation will proceed (harvester.install.skipchecks = true)")to make it explicit when preflight checks fail but are intentionally skipped.Related Issue:
harvester/harvester#6214
Test plan:
/var/log/console.log, rather than only appearing on the console.For example, with this configuration:
...we should see something like the following on the console:
...and something like this in the log:
This is an automatic backport of pull request #775 done by [Mergify](https://mergify.com).