Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addon version check with the repo (backport #750) #781

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 26, 2024

Problem:

Addon & repo chart version mis-matching (e.g. harvester/harvester#5840)

Solution:

Check version matching in the step of build-bundle

In amd64 architecture, the mismatching will cause build failure
In arm64 architecture, the mismatching will print some WARNING messages but build continue

Related Issue:
harvester/harvester#4937
harvester/harvester#5840

Test plan:

make iso output:
amd64

...
charts packed in Harvester repo
total 1.3M
drwxr-xr-x 2 root root 4.0K Jun  3 18:35 .
-rw-r--r-- 1 root root  12K Jun  3 18:35 index.yaml
-rw-r--r-- 1 root root 2.5K Jun  3 18:35 nvidia-driver-runtime-0.1.1.tgz
-rw-r--r-- 1 root root 3.0K Jun  3 18:35 harvester-seeder-0.1.1.tgz
-rw-r--r-- 1 root root 2.8K Jun  3 18:35 harvester-pcidevices-controller-0.3.2.tgz
-rw-r--r-- 1 root root 2.6K Jun  3 18:35 harvester-vm-import-controller-0.1.8.tgz
-rw-r--r-- 1 root root  15K Jun  3 18:35 rancher-logging-103.0.0+up3.17.10.tgz
-rw-r--r-- 1 root root  82K Jun  3 18:35 rancher-logging-crd-103.0.0+up3.17.10.tgz
-rw-r--r-- 1 root root 398K Jun  3 18:35 rancher-monitoring-crd-103.0.3+up45.31.1.tgz
-rw-r--r-- 1 root root 416K Jun  3 18:35 rancher-monitoring-103.0.3+up45.31.1.tgz
-rw-r--r-- 1 root root  66K Jun  3 18:34 harvester-crd-0.0.0-master-f9464f06.tgz
-rw-r--r-- 1 root root 211K Jun  3 18:34 harvester-0.0.0-master-f9464f06.tgz
drwxrwxr-x 1 root root 4.0K Jun  3 18:34 ..
addon template files
total 16K
drwxr-xr-x 2 root root 4.0K Jun  3 18:34 .
drwxr-xr-x 4 root root 4.0K Jun  3 18:34 ..
-rw-r--r-- 1 root root 7.2K Jun  3 18:34 rancherd-22-addons.yaml
addon: harvester-vm-import-controller version: 0.1.8
addon: harvester-pcidevices-controller version: 0.3.2
addon: rancher-logging version: 103.0.0+up3.17.10
addon: rancher-monitoring version: 103.0.3+up45.31.1
addon: harvester-seeder version: 0.1.1
addon: nvidia-driver-runtime version: 0.1.1

arm64:

...
drwxr-xr-x 2 root root 4.0K Jun  3 18:37 .
-rw-r--r-- 1 root root  11K Jun  3 18:37 index.yaml
-rw-r--r-- 1 root root 2.5K Jun  3 18:37 nvidia-driver-runtime-0.1.1.tgz
-rw-r--r-- 1 root root  15K Jun  3 18:37 rancher-logging-103.0.0+up3.17.10.tgz
-rw-r--r-- 1 root root  82K Jun  3 18:37 rancher-logging-crd-103.0.0+up3.17.10.tgz
-rw-r--r-- 1 root root 398K Jun  3 18:37 rancher-monitoring-crd-103.0.3+up45.31.1.tgz
-rw-r--r-- 1 root root 417K Jun  3 18:37 rancher-monitoring-103.0.3+up45.31.1.tgz
-rw-r--r-- 1 root root  66K Jun  3 18:37 harvester-crd-0.0.0-master-f9464f06.tgz
-rw-r--r-- 1 root root 215K Jun  3 18:37 harvester-0.0.0-master-f9464f06.tgz
drwxr-xr-x 1 root root 4.0K Jun  3 18:37 ..
addon template files
total 16K
drwxr-xr-x 2 root root 4.0K Jun  3 18:37 .
drwxr-xr-x 4 root root 4.0K Jun  3 18:37 ..
-rw-r--r-- 1 root root 7.2K Jun  3 18:37 rancherd-22-addons.yaml
addon: harvester-vm-import-controller version: 0.1.8
WARNING: addon harvester-vm-import-controller is defined with version 0.1.8 but the chart is not packed into repo in arm64
addon: harvester-pcidevices-controller version: 0.3.2
WARNING: addon harvester-pcidevices-controller is defined with version 0.3.2 but the chart is not packed into repo in arm64
addon: rancher-logging version: 103.0.0+up3.17.10
addon: rancher-monitoring version: 103.0.3+up45.31.1
addon: harvester-seeder version: 0.1.1
WARNING: addon harvester-seeder is defined with version 0.1.1 but the chart is not packed into repo in arm64
addon: nvidia-driver-runtime version: 0.1.1
```<hr>This is an automatic backport of pull request #750 done by [Mergify](https://mergify.com).

Signed-off-by: Jian Wang <[email protected]>
(cherry picked from commit 24a8e73)
@tserong tserong self-requested a review July 30, 2024 06:23
Copy link
Contributor

@ibrokethecloud ibrokethecloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks.

@tserong tserong merged commit 650fdcc into v1.4 Jul 30, 2024
6 checks passed
@mergify mergify bot deleted the mergify/bp/v1.4/pr-750 branch July 30, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants