Enhancement: Add IP mask field to Network Panel #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is now in conflict. Could you fix it @mingshuoqiu? 🙏 |
bk201
reviewed
Dec 27, 2024
mingshuoqiu
force-pushed
the
issue_6295
branch
from
046abb3 to
4c257bb
Compare
|
@mingshuoqiu the commits need a clean-up. Please rebase on the target branch when seeing a conflict. |
mingshuoqiu
force-pushed
the
issue_6295
branch
from
404cc84 to
c73d811
Compare
Add IP mask field to provide better network configuration options: - Display calculated netmask when CIDR notation is used - Allow manual netmask input for non-CIDR IP addresses Signed-off-by: Chris Chiu <[email protected]>
mingshuoqiu
force-pushed
the
issue_6295
branch
from
c73d811 to
bce3c19
Compare
|
I tested the installer and saw this before the installation was just about to kick off Here is the log: |
|
@mingshuoqiu I can reproduce the same error with master ISO, we might have some changes that break the static IP method recently. v1.4.0 ISO is fine. |
|
Create a new issue to track, the key is to use a static VIP. @ihcsim could be this caused by recent changes of the VIP panel? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add IP mask field to provide better network configuration options:
Problem:
Allow users to specify the address as either
<address>/<netmask>or CIDR.Solution:
Display calculated netmask when CIDR notation is used. And validate the netmask input for non-CIDR IP addresses
Related Issue:
harvester/harvester#6295
Test plan:
IPv4 MaskfieldIPv4 Addressfield and check if the netmask generated correctly in theIPv4 Maskfield