Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect unit in cpu usage dashboard #908

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

brandboat
Copy link
Member

@brandboat brandboat commented Dec 25, 2024

Problem:

Prometheus VM Metrics are not accurate whatsoever where cpu usage metrics at a percentage level are exceeding 200000% within the Harvester UI VM metrics.

Solution:

fix incorrect cpu usage unit, upgrade path fix is here: harvester/harvester#7250

Related Issue:
harvester/harvester#7086

Test plan:

  • Prepare a harvester cluster with this patch
  • Enable rancher-monitoring addon
  • Prepare some VMs (e.g. 3 VM)
  • Goto Grafana UI and wait for a couple of minutes
  • Check the value of cpu usage should fall in range [0, 100] in both Harvester VM Dashboard and Harvester VM Info Detail dashboards (during vm startup, the cpu usage may slightly go over 100%, after a while it should dramatically drop to a low value, like 2%)

Copy link
Member

@starbops starbops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@starbops starbops merged commit 0c43ec2 into harvester:master Dec 25, 2024
7 checks passed
@brandboat brandboat deleted the HARV-7086 branch January 2, 2025 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants