arm upgrade fix: patch harvester-release.yaml for arm iso builds #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lds. This change is needed to ensure correct kubevirt version is included in the harvester-release.yaml. This is essential to ensure the upgrade manifests script can succesfully reconcile the kubevirt version with expected version as part of the upgrade process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Currently the harvester iso build includes the kubevirt version from the values.yaml file in the harvester/harvester chart.
During the ARM packaging we patch the kubevirt version to upstream version, to allow correct images to be included in the packaging.
However the changes are reverted before the OS packaging, which results in the
harvester-release.yamlcontaining the values from the amd64 build.This causes the upgrade to fail as the upgrade helper waits for the kubevirt version to be the one defined in the
harvester-release.yaml. This never reconciles as we end up using the amd64 kubevirt patch version which results in an upgrade being stuck.Solution:
minor changes to allow patching of harvester-release.yaml for ARM builds. This change is needed to ensure correct kubevirt version is included in the harvester-release.yaml. This is essential to ensure the upgrade manifests script can successfully reconcile the kubevirt version with expected version as part of the upgrade process
Related Issue:
harvester/harvester#6257
Test plan:
To test: