Skip to content

Commit

Permalink
Implement schedulingVMBackup feature flag
Browse files Browse the repository at this point in the history
Signed-off-by: Francesco Torchia <[email protected]>
  • Loading branch information
torchiaf authored and a110605 committed Nov 12, 2024
1 parent ff7bcbb commit c55bbbe
Show file tree
Hide file tree
Showing 3 changed files with 43 additions and 10 deletions.
22 changes: 18 additions & 4 deletions pkg/harvester/list/harvesterhci.io.virtualmachinebackup.vue
Original file line number Diff line number Diff line change
Expand Up @@ -124,12 +124,18 @@ export default {
align: 'left',
formatter: 'AttachVMWithName'
},
{
];
if (this.schedulingVMBackupFeatureEnabled) {
cols.push({
name: 'backupCreatedFrom',
labelKey: 'harvester.tableHeaders.vmSchedule',
value: 'sourceSchedule',
formatter: 'BackupCreatedFrom',
},
});
}
cols.push(...[
{
name: 'backupTarget',
labelKey: 'tableHeaders.backupTarget',
Expand All @@ -144,7 +150,7 @@ export default {
align: 'center',
formatter: 'Checked',
},
];
]);
if (this.hasBackupProgresses) {
cols.push({
Expand All @@ -155,11 +161,16 @@ export default {
formatter: 'HarvesterBackupProgressBar',
});
}
cols.push(AGE);
return cols;
},
schedulingVMBackupFeatureEnabled() {
return this.$store.getters['harvester-common/getFeatureEnabled']('schedulingVMBackup');
},
hasBackupProgresses() {
return !!this.backups.find((r) => r.status?.progress !== undefined);
},
Expand Down Expand Up @@ -244,7 +255,10 @@ export default {
key-field="_key"
default-sort-by="age"
>
<template #more-header-middle>
<template
v-if="schedulingVMBackupFeatureEnabled"
#more-header-middle
>
<FilterVMSchedule
:rows="getRawRows"
@change-rows="changeRows"
Expand Down
25 changes: 20 additions & 5 deletions pkg/harvester/list/harvesterhci.io.vmsnapshot.vue
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export default {
computed: {
headers() {
return [
const cols = [
STATE,
NAME,
NAMESPACE,
Expand All @@ -70,13 +70,19 @@ export default {
sort: 'attachVM',
formatter: 'AttachVMWithName'
},
{
];
if (this.schedulingVMBackupFeatureEnabled) {
cols.push({
name: 'backupCreatedFrom',
labelKey: 'harvester.tableHeaders.vmSchedule',
value: 'sourceSchedule',
sort: 'sourceSchedule',
formatter: 'BackupCreatedFrom',
},
});
}
cols.push(...[
{
name: 'readyToUse',
labelKey: 'tableHeaders.readyToUse',
Expand All @@ -86,7 +92,13 @@ export default {
formatter: 'Checked',
},
AGE
];
]);
return cols;
},
schedulingVMBackupFeatureEnabled() {
return this.$store.getters['harvester-common/getFeatureEnabled']('schedulingVMBackup');
},
getRawRows() {
Expand Down Expand Up @@ -142,7 +154,10 @@ export default {
key-field="_key"
default-sort-by="age"
>
<template #more-header-middle>
<template
v-if="schedulingVMBackupFeatureEnabled"
#more-header-middle
>
<FilterVMSchedule
:rows="getRawRows"
@change-rows="changeRows"
Expand Down
6 changes: 5 additions & 1 deletion pkg/harvester/models/kubevirt.io.virtualmachine.js
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ export default class VirtVm extends HarvesterResource {
},
{
action: 'createSchedule',
enabled: true,
enabled: this.schedulingVMBackupFeatureEnabled,
icon: 'icon icon-history',
label: this.t('harvester.action.createSchedule')
},
Expand Down Expand Up @@ -1147,6 +1147,10 @@ export default class VirtVm extends HarvesterResource {
}
}

get schedulingVMBackupFeatureEnabled() {
return this.$rootGetters['harvester-common/getFeatureEnabled']('schedulingVMBackup');
}

setInstanceLabels(val) {
if ( !this.spec?.template?.metadata?.labels ) {
set(this, 'spec.template.metadata.labels', {});
Expand Down

0 comments on commit c55bbbe

Please sign in to comment.