fix: failed to resume /active vm schedule job #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a110605
changed the title
Signed-off-by: andy.lee <[email protected]>
a110605
added a commit
that referenced
this pull request
Jan 10, 2025
….5/pr-69 fix: failed to resume /active vm schedule job (backport #69)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is a sudden
harvesterhci.io.schedulevmbackupwebsocket changes data object missingmetadata.state.name.See
PR Checklists
Related Issue
harvester/harvester#7174
Test screenshot/video
Screen.Recording.2025-01-08.at.4.00.47.PM.mov
Extra technical notes summary
After synced with @WebberHuang1118 , we can consume
status.suspended = trueto determine schedule job is suspended or not. There is no other status for schedule job so far.We can enhance get state() if backend has other status in the future.
see HEP : https://github.com/harvester/harvester/blob/master/enhancements/20240611-vm-schedule-backup.md#crd