Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing wording in delete VM modal (backport #79) #82

Merged

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 13, 2025

Summary

Add missing wording in delete VM modal.
The warning and info messages are put in LabeledInput in latest shell PromptRemove.vue .

So I added message in harvester custom promptRemove.

PR Checklists

  • Do we need to backport this PR change to the Harvester Dashboard?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue

harvester/harvester#7317

Test screenshot/video

Delete single VM

Screenshot 2025-01-10 at 4 53 40 PM

Delete multiple VM
Screenshot 2025-01-10 at 5 01 34 PM

Extra technical notes summary


This is an automatic backport of pull request #79 done by [Mergify](https://mergify.com).

Signed-off-by: andy.lee <[email protected]>
(cherry picked from commit 7e32ea4)
@a110605 a110605 merged commit b96637e into release-harvester-v1.5 Jan 13, 2025
2 checks passed
@a110605 a110605 deleted the mergify/bp/release-harvester-v1.5/pr-79 branch January 13, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant