Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sortablejs-vue3 #86

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Conversation

torchiaf
Copy link
Collaborator

@torchiaf torchiaf commented Jan 13, 2025

Summary

PR Checklists

  • Do we need to backport this PR change to the Harvester Dashboard?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue harvester/harvester#7363

Test screenshot/video

Extra technical notes summary

Signed-off-by: Francesco Torchia <[email protected]>
@torchiaf torchiaf force-pushed the replace-sortablejs-vue3 branch from 3b6fc51 to a7b4366 Compare January 13, 2025 17:13
@a110605
Copy link
Collaborator

a110605 commented Jan 14, 2025

Push this PR commit to issue7363-dev branch to generate ui-index.

https://releases.rancher.com/harvester-ui/dashboard/issue7363-dev/index.html

Both are looks good to me.

  • Standalone mode
fix_volumes.mov
  • Integration mode
fix_integration.mov

Signed-off-by: Francesco Torchia <[email protected]>
@torchiaf torchiaf marked this pull request as ready for review January 14, 2025 09:10
@a110605
Copy link
Collaborator

a110605 commented Jan 14, 2025

@torchiaf , could you take a look why can't continually type volume name ?

Change ui-index to https://releases.rancher.com/harvester-ui/dashboard/issue7363-dev/index.html can reproduce.

bug-typing.mov

Signed-off-by: Francesco Torchia <[email protected]>
@torchiaf torchiaf requested a review from a110605 January 14, 2025 10:46
Copy link
Collaborator

@a110605 a110605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@Vicente-Cheng
Copy link
Contributor

Tested with UI index https://releases.rancher.com/harvester-ui/dashboard/issue7363-dev/index.html

Everything works well again. Thanks!

@torchiaf torchiaf merged commit 7b6efa6 into harvester:main Jan 14, 2025
2 checks passed
@mergify mergify bot mentioned this pull request Jan 14, 2025
2 tasks
a110605 added a commit that referenced this pull request Jan 15, 2025
….5/pr-86

Replace sortablejs-vue3 (backport #86)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants