Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove witness node in VM node scheduling tab #89

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix: remove witness node in VM node scheduling tab #89

merged 1 commit into from
Jan 20, 2025

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Jan 14, 2025 •
edited
Loading

Summary

fix: remove witness node in VM node scheduling tab

PR Checklists

  • Do we need to backport this PR change to the Harvester Dashboard?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue

harvester/harvester#6592

Test screenshot/video

Harvester-node-1 is witness node.

Screenshot 2025-01-17 at 3 25 54 PM Screenshot 2025-01-17 at 3 25 47 PM

@a110605 a110605 self-assigned this Jan 14, 2025
torchiaf
torchiaf reviewed Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not wrong, we used a label to identify witness nodes.
Otherwise LGTM

@a110605 a110605 changed the title fix: remove witness node in VM node scheduling tab (TESTING) fix: remove witness node in VM node scheduling tab Jan 17, 2025
@a110605
Copy link
Collaborator Author

a110605 commented Jan 17, 2025 •
edited
Loading

If I'm not wrong, we used a label to identify witness nodes. Otherwise LGTM

We used annotation node-role.harvesterhci.io/witness to identify this node is witness node or not.

@a110605 a110605 requested a review from torchiaf January 17, 2025 07:38
houhoucoop
houhoucoop approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@houhoucoop houhoucoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@torchiaf
Copy link
Collaborator

If I'm not wrong, we used a label to identify witness nodes. Otherwise LGTM

We used annotation node-role.harvesterhci.io/witness to identify this node is witness node or not.

So should we use that label also in the current change?

@a110605
Copy link
Collaborator Author

a110605 commented Jan 20, 2025 •
edited
Loading

If I'm not wrong, we used a label to identify witness nodes. Otherwise LGTM

We used annotation node-role.harvesterhci.io/witness to identify this node is witness node or not.

So should we use that label also in the current change?

isEtcd() is checking node-role.harvesterhci.io/witness annotation.

@a110605 a110605 merged commit cb4cdcb into harvester:main Jan 20, 2025
2 checks passed
@mergify mergify bot mentioned this pull request Jan 20, 2025
Merged
2 tasks
a110605 added a commit that referenced this pull request Jan 20, 2025
@a110605
Merge pull request #100 from harvester/mergify/bp/release-harvester-v…
752cf2e 
…1.5/pr-89

fix: remove witness node in VM node scheduling tab (backport #89)
@a110605 a110605 deleted the issue_6592 branch January 22, 2025 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houhoucoop houhoucoop houhoucoop approved these changes

@torchiaf torchiaf torchiaf approved these changes

Assignees

@a110605 a110605

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a110605 @torchiaf @houhoucoop