fix: encrypt option can only choose encrypted storage class when creating VM image #93
Conversation
… creating image Signed-off-by: andy.lee <[email protected]>
a110605
changed the title
| const defaultStorage = this.$store.getters[`${ inStore }/all`](STORAGE_CLASS).find((s) => s.isDefault); | ||
|
|
||
| // if default sc is encrypted, use longhorn as default | ||
| return defaultStorage.isEncrypted ? LONGHORN : defaultStorage?.metadata?.name; |
There was a problem hiding this comment.
Is there any chance that longhorn could be deleted, or is it not deletable?
There was a problem hiding this comment.
Longhorn sc can be deleted from UI. But backend won't actually delete it.
cc @Vicente-Cheng
There was a problem hiding this comment.
That was actually deleted but soon was recreated by someone...
|
|
||
| defaultStorageClassName() { | ||
| const inStore = this.$store.getters['currentProduct'].inStore; | ||
| const defaultStorage = this.$store.getters[`${ inStore }/all`](STORAGE_CLASS).find((s) => s.isDefault); |
There was a problem hiding this comment.
fallback to longhorn is there is no defaultStorage?
There was a problem hiding this comment.
Good idea. If there is no default SC, we can fallback to longhorn.
| if (this.value.spec?.securityParameters?.cryptoOperation === ENCRYPT) { | ||
| this.storageClassName = this.encryptedStorageClasses[0]?.name || LONGHORN; | ||
| } else { // URL / FILE / DECRYPT should use default storage class | ||
| this.storageClassName = this.defaultStorageClassName(); |
There was a problem hiding this comment.
We use this.value.metadata.annotations[HCI_ANNOTATIONS.STORAGE_CLASS] to retrieve the storageClassName on line 177.
Is this value always be the same of this.$store.getters[${ inStore }/all](STORAGE_CLASS).find((s) => s.isDefault)?
There was a problem hiding this comment.
updated in 6e9350e
Signed-off-by: andy.lee <[email protected]>
Summary
PR Checklists
Related Issue
harvester/harvester#6792
Test screenshot/video
feature_img.mov