feat: add confirmation pop-up for VM stop and pause actions #94
Conversation
Signed-off-by: Yi-Ya Chen <[email protected]>
| .actions { | ||
| text-align: right; | ||
| } | ||
| </style> |
There was a problem hiding this comment.
Copy the dialog content from https://github.com/harvester/harvester-ui-extension/blob/main/pkg/harvester/dialog/ConfirmRelatedToRemoveDialog.vue.
We can modify the component if we prefer a simpler confirmation pop-up.
| stop: | ||
| message: "Are you sure you want to continue stop the {type} {names}?" | ||
| pause: | ||
| message: "Are you sure you want to continue pause the {type} {names}?" |
There was a problem hiding this comment.
Copy most of the wording from Rancher.
ref: https://github.com/rancher/dashboard/blob/36d8a069eee391f916ca97f6c2b0f04d1bbb8db6/shell/assets/translations/en-us.yaml#L4764-L4779
| </h4> | ||
| </template> | ||
|
|
||
| <template #body> |
There was a problem hiding this comment.
I don't think we need to input the VM name to stop or pause a VM.
An alert modal is enough. User can press cmd key to bypass the popup modal.
Signed-off-by: Yi-Ya Chen <[email protected]>
|
TODO: Test bulk action functionality |
|
@houhoucoop I agree with Andy, I would avoid typing vm name for confirmation. Otherwise LGTM |
Summary
StoporPauseaction is clickedCommandkey while clicking the actionPR Checklists
Related Issue
[ENHANCEMENT] Add confirmation pop-up for VM stop and pause actions #7382
Test screenshot/video
Confirm pop-up for stop VM
Confirm pop-up for pause VM
Extra technical notes summary
N/A