Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Can't delete Storage disk #5726

Closed
abonillabeeche opened this issue May 2, 2024 · 5 comments
Closed

[BUG] Can't delete Storage disk #5726

abonillabeeche opened this issue May 2, 2024 · 5 comments
Assignees
Labels
area/node-disk-manager backport-needed/1.2.3 backport-needed/1.3.1 kind/bug Issues that are defects reported by users or that we know have reached a real release priority/1 Highly recommended to fix in this release reproduce/always Reproducible 100% of the time severity/needed Reminder to add a severity label and to remove this one
Milestone

Comments

@abonillabeeche
Copy link

Describe the bug
Deleting a Storage device from the UI doesn't work. I had to go into Longhorn and delete the disk after eviction/scheduling is disabled

To Reproduce
Hosts -> Edit Config -> Storage -> X on the Disk to remove -> Save
Hosts -> Edit Config -> Storage - Disk is still there.

Refer to https://suse.slack.com/archives/C02CN3TT61M/p1714679403477409

Expected behavior
Disk should be removed. Instead one has to go into Longhorn and remove the disk.

Environment

  • Harvester ISO version: 1.3.0
  • Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): R620
@abonillabeeche abonillabeeche added kind/bug Issues that are defects reported by users or that we know have reached a real release reproduce/needed Reminder to add a reproduce label and to remove this one severity/needed Reminder to add a severity label and to remove this one labels May 2, 2024
@Vicente-Cheng Vicente-Cheng self-assigned this May 3, 2024
@bk201 bk201 added this to the v1.4.0 milestone May 9, 2024
@bk201 bk201 added priority/1 Highly recommended to fix in this release reproduce/always Reproducible 100% of the time backport-needed/1.3.1 backport-needed/1.2.3 and removed reproduce/needed Reminder to add a reproduce label and to remove this one labels May 9, 2024
@harvesterhci-io-github-bot
Copy link
Collaborator

added backport-needed/1.3.1 issue: #5778.

@harvesterhci-io-github-bot
Copy link
Collaborator

added backport-needed/1.2.3 issue: #5779.

@harvesterhci-io-github-bot
Copy link
Collaborator

harvesterhci-io-github-bot commented May 10, 2024

Pre Ready-For-Testing Checklist

* [ ] If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted?
The HEP PR is at:

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

Test Plan: please refer to harvester/node-disk-manager#102

  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

Remove this disk on LH UI directly

* [ ] If labeled: area/ui Has the UI issue filed or ready to be merged?
The UI issue/PR is at:

* [ ] If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged?
The documentation/KB PR is at:

* [ ] If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?
- The automation skeleton PR is at:
- The automation test case PR is at:

* [ ] If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
The compatibility issue is filed at:

@harvesterhci-io-github-bot
Copy link
Collaborator

Automation e2e test issue: harvester/tests#1261

@irishgordo
Copy link
Contributor

@Vicente-Cheng -thanks for this 😄 👍 - this looks good on Harvester Version: master-9c0a3a1-head

On a bare-metal HP DL160, 3 Node Cluster, the disk can be removed physically from the node and then cleaned up appropriately on Harvester & Longhorn UI

PXL_20240703_233032549
PXL_20240703_233043764
Screenshot from 2024-07-03 16-33-32
Screenshot from 2024-07-03 16-32-48
Screenshot from 2024-07-03 16-32-14
Screenshot from 2024-07-03 16-31-34

Disk was provisioned and schedulable, prior - via extra storage class etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/node-disk-manager backport-needed/1.2.3 backport-needed/1.3.1 kind/bug Issues that are defects reported by users or that we know have reached a real release priority/1 Highly recommended to fix in this release reproduce/always Reproducible 100% of the time severity/needed Reminder to add a severity label and to remove this one
Projects
None yet
Development

No branches or pull requests

5 participants