controller: improve the mechanism of disk removing (backport #102) #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
|
introduce the executor to v0.6.x for this backport. |
1 task
- that we can drop some dependency Signed-off-by: Vicente Cheng <[email protected]> (cherry picked from commit caaaf6b)
Signed-off-by: Vicente Cheng <[email protected]> (cherry picked from commit ab2c939)
- We should not skip the inactive/corrupted device by removing op
- Improve the order of onChange. Now, we will handle the removal
first and the addition/update later. That helps the logic be clarified.
Signed-off-by: Vicente Cheng <[email protected]>
(cherry picked from commit d699409)
Signed-off-by: Vicente Cheng <[email protected]> (cherry picked from commit 3a9b364)
- we need to remove the duplicated disk after we tested Signed-off-by: Vicente Cheng <[email protected]> (cherry picked from commit 61307c8)
Signed-off-by: Vicente Cheng <[email protected]> (cherry picked from commit 969ccdc)
Vicente-Cheng
force-pushed
the
mergify/bp/v0.6.x/pr-102
branch
from
edb71af to
0df11a0
Compare
bk201
approved these changes
May 23, 2024
tserong
approved these changes
May 23, 2024
There was a problem hiding this comment.
LGTM.
Question (because I was diffing branches and playing with git cherry -v to review this): should #100 also be backported to v0.6.x? AFAICT the two commits in that PR will be the only ones in master that aren't in v0.6.x once this PR is merged.
Yeah, we should backport the PR you mentioned. These two PRs are not related; I prefer to split them. Thanks! |
votdev
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When the disk is gone, we cannot remove it on Harvester UI.
That's a regression after we introduce the inactive/corrupted concept.
Solution:
Improve the removing disk mechanism.
Related Issue:
harvester/harvester#5726
Test plan:
Nice to Have:
This is an automatic backport of pull request controller: improve the mechanism of disk removing #102 done by Mergify.