Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated header/add "More from SUSE" dropdown #48

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

LucasSaintarbor
Copy link
Collaborator

Added "More from SUSE" dropdown. Updating the header and footer for Harvester home page to the standard across other projects for SUSE Rancher.

Screenshot 2023-11-02 at 2 32 28 PM

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for harvester-home-preview ready!

Name Link
🔨 Latest commit f49ebda
🔍 Latest deploy log https://app.netlify.com/sites/harvester-home-preview/deploys/654418b71402d40008380daf
😎 Deploy Preview https://deploy-preview-48--harvester-home-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LucasSaintarbor LucasSaintarbor requested a review from btat November 2, 2023 21:34
Copy link

@btat btat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should omit the images that aren't used.

@LucasSaintarbor
Copy link
Collaborator Author

https://deploy-preview-48--harvester-home-preview.netlify.app

Thanks! Removing the images now

@LucasSaintarbor LucasSaintarbor merged commit d7f3ca8 into harvester:main Nov 2, 2023
4 checks passed
@bk201
Copy link
Member

bk201 commented Nov 3, 2023

@LucasSaintarbor wondering if this PR causes the KB page can't be accessed from the first page of https://harvesterhci.io/. Previously I could find the KB button at the top of the page. Now I need to got to the doc site first and then click the "quick links" at the top -> Knowledge Base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants