Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dhcp client package #102

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

w13915984028
Copy link
Member

Problem:

The vendor github.com/insomniacslk/dhcp was old

Solution:

Bump to latest

Related Issue:
Partially related to harvester/harvester#3428

Test plan:

  1. create VM network
  2. dhcp detect should be successful

Signed-off-by: Jian Wang <[email protected]>
Copy link
Member

@starbops starbops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with newly created VM Networks. LGTM, thank you.

Copy link
Contributor

@mingshuoqiu mingshuoqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested w/o problem. Thanks

@w13915984028 w13915984028 merged commit cfd78ad into harvester:master Jul 24, 2024
3 checks passed
@starbops
Copy link
Member

starbops commented Aug 7, 2024

@w13915984028 since it's a bug fix, do we want to backport it to v0.4.x (corresponds to Harvester v1.3). And we've cut another branch v0.5.x for Harvester v1.4 release, we need to backport this to v0.5.x branch, too.

cc @mingshuoqiu

@w13915984028
Copy link
Member Author

@starbops I did not notice there are also branchs here.
Backport v0.5.x is required, for v0.4.x we can also give it a try. thanks.

@w13915984028
Copy link
Member Author

@mergify backport v0.4.x v0.5.x

Copy link

mergify bot commented Aug 7, 2024

backport v0.4.x v0.5.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants