Renovate/master go go.opentelemetry.io contrib instrumentation net http otelhttp vulnerability #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Chiu <[email protected]>wq
otelhttp requires the otel, k8s.io and wrangler to be updated. Signed-off-by: Chris Chiu <[email protected]>
fix the compile error since the indexeres.VMByNetworkIndex is deprecated since harvester 1.4.0 pkg/utils/vmi.go:23:34: undefined: indexeres.VMByNetworkIndex pkg/utils/vmi.go:27:47: undefined: indexeres.VMByNetworkIndex pkg/utils/vmi.go:32:50: undefined: indexeres.VMByNetworkIndex FATA[0126] exit status 1 make: *** [Makefile:11: ci] Error 1 Signed-off-by: Chris Chiu <[email protected]>
mingshuoqiu
force-pushed
the
renovate/master-go-go.opentelemetry.io-contrib-instrumentation-net-http-otelhttp-vulnerability
branch
from
894c665 to
490938d
Compare
starbops
approved these changes
Jan 8, 2025
| @@ -49,3 +53,15 @@ func (v *VmiGetter) WhoUseNad(nad *nadv1.NetworkAttachmentDefinition, nodesFilte | |||
|
|
|||
| return afterFilter, nil | |||
| } | |||
|
|
|||
| func vmiByNetwork(obj *kubevirtv1.VirtualMachineInstance) ([]string, error) { | |||
There was a problem hiding this comment.
Do we want to align the naming between the label and the function to both vmi?
|
I guess the PR should just target the right stable branch or master, not to the renovate branch |
|
Create a new PR to fix the merge base |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Fix the compile error caused by module dependency #135 (comment)
Solution:
Add and update the required packages
Related Issue:
Test plan: