common: bump go v1.23 #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mergifyio backport v0.7.x |
✅ Backports have been created
|
Signed-off-by: Vicente Cheng <[email protected]>
Vicente-Cheng
force-pushed
the
bump-go-1.23
branch
from
073524b to
6b0bb05
Compare
bk201
approved these changes
Jan 9, 2025
tserong
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
LGTM, but you might also want to bump golangci-lint (I found that in @starbops work on harvester/vm-dhcp-controller#40)
Signed-off-by: Vicente Cheng <[email protected]>
Vicente-Cheng
force-pushed
the
bump-go-1.23
branch
from
6b0bb05 to
bb07ff3
Compare
golangci-lint bumped |
tserong
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
bump go v1.23
Solution:
bump go v1.23
Related Issue:
harvester/harvester#7336
Test plan:
CI passed