process: do not enable profiler by default #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we use `hostNetwork` because we need to listen uevent.
`hostNetwork` will expose any listen ports to host, so we
should prevent enable extra ports.
Signed-off-by: Vicente Cheng <[email protected]>
tserong
approved these changes
Dec 20, 2023
|
@Mergifyio backport v0.5.x |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
NDM created with the
hostNetwork: true. This parameter will expose the whole port on this pod to the host.So, we need to prevent listening to unnecessary ports on NDM pods.
Solution:
we can disable profiler by default. NDM does not use it generally.
Related Issue:
harvester/harvester#4212
Test plan:
make sure the host does not listen :6060