controller: add disk tags to BlockDeviceSpec (backport #60) #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
- Also bump golangci-lint to v1.55.2 Signed-off-by: Vicente Cheng <[email protected]> (cherry picked from commit 750c5d3)
Signed-off-by: Vicente Cheng <[email protected]> (cherry picked from commit 1a06d92)
- for slice related functions Signed-off-by: Vicente Cheng <[email protected]> (cherry picked from commit d39425a)
- we do not need the long jitter Signed-off-by: Vicente Cheng <[email protected]> (cherry picked from commit 129b968)
Now, the BlockDevices CR will handle its disk Tags. These tags
will deploy to the Longhorn node.
Some related fields,
- Blockdevice.Spec.Tags: Harvester defined disk Tags
- Blockdevice.Status.Tags: disk Tags from longhorn nodes and
Harvester defined
- disk.Tags of nodes.longhorn.io: disk Tags defined by both
harvester and longhorn
- change the variable name from needUpdated -> updated, that
will make it more readable.
Signed-off-by: Vicente Cheng <[email protected]>
(cherry picked from commit b3a7703)
- deploy longhorn v1.5.3
- update the deployment CRD
- Add tags with provision
- Remove tags from provisioned blockdevice
- Add tags to provisioned blockdevice
- Add more info with upgrade operation
Signed-off-by: Vicente Cheng <[email protected]>
(cherry picked from commit 44f601c)
3 tasks
bk201
approved these changes
Jan 22, 2024
tserong
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #60 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com