Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CloudInit CRD #19

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Add CloudInit CRD #19

merged 1 commit into from
Dec 19, 2023

Conversation

connorkuehl
Copy link

Related issue: harvester/harvester#4710

Related issue: harvester/harvester#4709


This is the first PR of a series to incrementally merge in a fully-functioning CloudInit custom resource and a webhook to help protect parts of the system that will be affected by the CloudInit controller (which will be added in a later PR).

The only non-generated code changes are in the diff for pkg/apis/node.harvesterhci.io/v1beta1/cloudinit.go.

Signed-off-by: Connor Kuehl <[email protected]>
Copy link
Member

@w13915984028 w13915984028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link
Contributor

@ibrokethecloud ibrokethecloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks.

@connorkuehl connorkuehl merged commit b8c50dc into harvester:master Dec 19, 2023
3 checks passed
@connorkuehl connorkuehl deleted the harv4710_crd branch December 19, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants