Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement webhook #24

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Implement webhook #24

merged 1 commit into from
Jan 11, 2024

Conversation

connorkuehl
Copy link

Related to: harvester/harvester#4710

Related to: harvester/harvester#4709


This PR adds the business logic for accepting or mutating CloudInit resources. Since the CloudInit controller in the node-manager will be overwriting files in /oem, it's important that the webhook maintains a list of system-level files to prevent overwriting them, as well as to prevent the controller from allowing multiple CloudInit resources to affect the same single file under /oem.

Signed-off-by: Connor Kuehl <[email protected]>
@connorkuehl
Copy link
Author

ping

Copy link
Contributor

@Vicente-Cheng Vicente-Cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Copy link
Contributor

@ibrokethecloud ibrokethecloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants