feat: Add ability to enable Longhorn V2 Data Engine #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 22, 2024
tserong
force-pushed
the
wip-lhv2-enablement
branch
from
2b534d1 to
562f1ad
Compare
|
(Force push was to fix lint errors) |
tserong
force-pushed
the
wip-lhv2-enablement
branch
from
562f1ad to
2c3f8eb
Compare
tserong
added a commit
to tserong/node-manager
that referenced
this pull request
Aug 23, 2024
Needed for harvester#55 Signed-off-by: Tim Serong <[email protected]>
Merged
|
I've opened #56 separately for the bump of go-common necessary to pick up |
Vicente-Cheng
pushed a commit
that referenced
this pull request
Aug 23, 2024
Needed for #55 Signed-off-by: Tim Serong <[email protected]>
|
This pull request is now in conflict. Could you fix it @tserong? 🙏 |
Signed-off-by: Tim Serong <[email protected]>
tserong
force-pushed
the
wip-lhv2-enablement
branch
from
2c3f8eb to
5a62092
Compare
|
Rebased |
bk201
approved these changes
Aug 26, 2024
brandboat
approved these changes
Aug 26, 2024
tserong
force-pushed
the
wip-lhv2-enablement
branch
from
5a62092 to
49cf969
Compare
This allows adding extra stages to oem/99_settings.yaml, independently of the NTP settings. Signed-off-by: Tim Serong <[email protected]>
Signed-off-by: Tim Serong <[email protected]>
Related issue: harvester/harvester#5274 Signed-off-by: Tim Serong <[email protected]>
tserong
force-pushed
the
wip-lhv2-enablement
branch
from
49cf969 to
c2ce0f2
Compare
|
@Mergifyio backport v0.3.x |
✅ Backports have been created
|
tserong
added a commit
that referenced
this pull request
Aug 28, 2024
Needed for #55 Signed-off-by: Tim Serong <[email protected]> (cherry picked from commit 0d0cfa2)
bk201
pushed a commit
that referenced
this pull request
Aug 28, 2024
Needed for #55 Signed-off-by: Tim Serong <[email protected]> (cherry picked from commit 0d0cfa2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
longhornConfigs.enableV2DataEngineto the node config CRD. When this value is set to true, we:It's probably easier to review this commit-by-commit, because I added some tests and did some refactoring first, to make sure I wasn't going to break the ntp config persistence.
Related issue: harvester/harvester#5274