Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copyright #67

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

brandboat
Copy link
Member

same as #66, but for v0.3.x branch.

Signed-off-by: Cooper Tseng <[email protected]>
@Vicente-Cheng
Copy link
Contributor

just curious, why don't we backport the master copyright commit to v0.3.x?

@brandboat
Copy link
Member Author

just curious, why don't we backport the master copyright commit to v0.3.x?

No specific reason actually... should I open another PR to address this?

@brandboat brandboat merged commit 2bbc402 into harvester:v0.3.x Jan 7, 2025
4 checks passed
@brandboat brandboat deleted the update-copy-right-v0.3.x branch January 7, 2025 02:05
@Vicente-Cheng
Copy link
Contributor

just curious, why don't we backport the master copyright commit to v0.3.x?

No specific reason actually... should I open another PR to address this?

In my personal opinion.
The version branch should backport the master commit in general cases.

Only in the following situations, we consider rewriting instead of backport

  • new commit based on the refactor
  • only need part of the new commit

But, all ok for this PR, NVM : )

@brandboat
Copy link
Member Author

In my personal opinion.
The version branch should backport the master commit in general cases.

Only in the following situations, we consider rewriting instead of backport

new commit based on the refactor
only need part of the new commit

Sorry for merging this PR too quickly; I thought you already approved this PR, but it wasn't... 🤦 My bad. I'll follow your suggestion, and it won't happen again next time. Thanks for your advice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants