* [e2e] implement hosts env utils

Signed-off-by: Francesco Torchia <[email protected]>
harvester · Jun 13, 2024 · 512c1bd · 512c1bd
1 parent 6e47deb
commit 512c1bd
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 10 deletions.
diff --git a/cypress/models/host.ts b/cypress/models/host.ts
@@ -0,0 +1,4 @@
+export interface Node {
+  name: string;
+  customName: string;
+}
diff --git a/cypress/pageobjects/hosts.po.ts b/cypress/pageobjects/hosts.po.ts
@@ -3,6 +3,7 @@ const constants = new Constants();
 import CruResourcePo from '@/utils/components/cru-resource.po';
 import { HCI } from '@/constants/types'
 import LabeledInputPo from '@/utils/components/labeled-input.po';
+import { Node } from '@/models/host'
 
 interface ValueInterface {
   namespace?: string,
@@ -12,11 +13,6 @@ interface ValueInterface {
   consoleUrl?: string,
 }
 
-export interface Node {
-  name: string;
-  customName: string;
-}
-
 export class HostsPage extends CruResourcePo {
   private hostList = '.host-list';
   private actionsDropdown = '.role-multi-action';

diff --git a/cypress/testcases/virtualmachines/node-scheduling.spec.ts b/cypress/testcases/virtualmachines/node-scheduling.spec.ts
@@ -1,6 +1,6 @@
 import { VmsPage } from "@/pageobjects/virtualmachine.po";
 
-import { generateName } from '@/utils/utils';
+import { generateName, host as hostUtil } from '@/utils/utils';
 import { Constants } from "@/constants/constants";
 
 const vmPO = new VmsPage();
@@ -27,7 +27,7 @@ describe('Stop VM Negative', () => {
     vmPO.setBasics('1', '1');
     vmPO.setVolumes(volume);
 
-    const hostList = Cypress.env('host');
+    const hostList = hostUtil.list();
     const host = hostList[0];
 
     vmPO.setNodeScheduling({

diff --git a/cypress/testcases/virtualmachines/scheduling.spec.ts b/cypress/testcases/virtualmachines/scheduling.spec.ts
@@ -1,5 +1,7 @@
 import { VmsPage } from "@/pageobjects/virtualmachine.po";
-import { HostsPage, Node } from "@/pageobjects/hosts.po";
+import { HostsPage } from "@/pageobjects/hosts.po";
+import { host as hostsUtil } from '@/utils/utils';
+import { Node } from '@/models/host'
 
 const vms = new VmsPage();
 const hosts = new HostsPage();
@@ -13,7 +15,7 @@ describe('VM scheduling on Specific node', () => {
   });
 
   it('Schedule VM on the Node which is Enable Maintenance Mode', () => {
-    const hostList = Cypress.env('host');
+    const hostList = hostsUtil.list();
 
     const hostNames: string[] = hostList.map((node: Node) => node.customName || node.name);
 

diff --git a/cypress/utils/utils.ts b/cypress/utils/utils.ts
@@ -1,5 +1,6 @@
 
 import AdmZip from 'adm-zip';
+import { Node } from '@/models/host'
 /**
  * This will validate the zip file by checking the contents. Assumes that this is in 
  * the downloads folder
@@ -47,7 +48,16 @@ export function base64Decode(string: string) {
   return !string ? string : base64DecodeToBuffer(string.replace(/[-_]/g, char => char === '-' ? '+' : '/')).toString();
 }
 
-export const nodes = {
+export const host = {
+  list(): Node[] {
+    const hosts = Cypress.env('host');
+
+    if (!hosts || hosts.length < 1) {
+      throw new Error("No hosts defined in cypress env");
+    }
+
+    return hosts;
+  },
   filterWitnessNode: (hosts: {name: string, witnessNode: boolean}[]) => {
     const ret = hosts.filter((host) => !host.witnessNode);