Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e2e] fix upgrade bugs #1248

Merged
merged 1 commit into from
May 6, 2024
Merged

[e2e] fix upgrade bugs #1248

merged 1 commit into from
May 6, 2024

Conversation

lanfon72
Copy link
Member

Changes

@lanfon72 lanfon72 requested a review from a team April 29, 2024 19:22
albinsun
albinsun approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@albinsun albinsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM.

harvester_e2e_tests/integrations/test_upgrade.py
def intercept_v121_vm(self, data):
if "v1.2.1" != api_client.cluster_version.raw:
return
if self._v121_vm:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps also drop class variable _v121_vm (Line 232) since it's only referenced by intercept_v121_vm?

@lanfon72 lanfon72 merged commit 94cedef into harvester:main May 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albinsun albinsun albinsun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lanfon72 @albinsun