Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] fix generate support bundle test #1258

Merged
merged 2 commits into from
May 9, 2024

Conversation

a110605
Copy link
Contributor

@a110605 a110605 commented May 8, 2024

Goal

  • Fix typo in some test cases description
  • Fix and stablize Generate support bundle test case.

Issue

#1195

Result

I ran mutliple times against to v1.3.0 harvester machine (https://172.19.108.23/) in ECM lab.
It average costs 1:55 ~ 2:10 min to generate and download the support bundle.

I increase the downloadTimeout to 240 second to avoid timeout issue and add some promise reject to make test case failed for any unexpected behavior.

Screenshot 2024-05-08 at 3 15 34 PM Screenshot 2024-05-08 at 3 36 18 PM

@a110605 a110605 requested review from TachunLin and lanfon72 and removed request for TachunLin May 8, 2024 08:11
@a110605 a110605 self-assigned this May 8, 2024
@a110605 a110605 requested a review from TachunLin May 8, 2024 08:11
@a110605 a110605 changed the title Fix generate support bundle test (WIP) Fix generate support bundle test (Under Testing) May 8, 2024
@a110605 a110605 force-pushed the fix_support_bundle branch from 6ea14d9 to c8d2ea0 Compare May 8, 2024 08:14
@a110605 a110605 changed the title Fix generate support bundle test (Under Testing) Fix generate support bundle test May 9, 2024
@a110605
Copy link
Contributor Author

a110605 commented May 9, 2024

Verified the change is good to pass on v1.2-head harvester (https://10.84.132.32).

It average costs 3:15 ~ 3:20 mins to gen and download support bundle.

Screenshot 2024-05-09 at 10 37 06 AM

@a110605 a110605 changed the title Fix generate support bundle test [e2e] fix generate support bundle test May 9, 2024
@khushboo-rancher
Copy link
Collaborator

Thanks @a110605 For the fix.
For future, you can consider naming the PR starting with cypress, we generally use e2e for the backend test. :)

@khushboo-rancher khushboo-rancher merged commit 57d71ad into harvester:main May 9, 2024
3 checks passed
@a110605
Copy link
Contributor Author

a110605 commented May 10, 2024

Thanks @a110605 For the fix. For future, you can consider naming the PR starting with cypress, we generally use e2e for the backend test. :)

Sure, thanks for let me know the convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants