[e2e] implement vm template related function and test case #1341

lanfon72 · 2024-06-25T20:47:28Z

Changes

ADD TemplateSpec
ADD create_template in VM manager
UPDATE TemplateManager to use TemplateSpec
UPDATE VMSpec to load volume claim correctly
UPDATE existing vm template test case structure
ADD test_create_vm_from_template_with_data to close [e2e] [BUG] Harvester v120 cann't start new VM from saved VM template #1194

albinsun

Having a trial run on harvester-runtests#15 but hit fail

Here data['spec']['defaultVersionId'] is an empty string.
Do we miss something here?

apiclient/harvester_api/managers/virtualmachines.py

lanfon72 · 2024-06-27T03:53:44Z

update to fix the timing bug in checking template version

albinsun

LGTM

harvester_e2e_tests/integrations/test_4_vm_template.py

lanfon72 added 3 commits June 26, 2024 04:29

+ [e2e] implement template spec

f5a9a29

* [e2e] update template manager and related test cases

41e983a

[apiclient] improve VMSpec and add vm.create_template

9be7202

lanfon72 requested a review from a team June 25, 2024 20:47

albinsun reviewed Jun 27, 2024

View reviewed changes

apiclient/harvester_api/managers/virtualmachines.py Show resolved Hide resolved

+ [e2e] new test case *create_vm_from_template*

d9e7d81

lanfon72 force-pushed the integration branch from 199dac3 to d9e7d81 Compare June 27, 2024 03:31

albinsun approved these changes Jun 28, 2024

View reviewed changes

harvester_e2e_tests/integrations/test_4_vm_template.py Show resolved Hide resolved

lanfon72 merged commit 64d8b19 into harvester:main Jul 1, 2024
2 of 3 checks passed