Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue #1083
What this PR does / why we need it:
test_1_images.py::TestImageWithStorageNetwork
to test image operations withinstorage-network
context, includes:create_image_by_file
download_image
delete_image
raise_on_status=False
on sessionretry_strategy
to let requests return5XX
response instead ofMax retries exceeded ...
error for handy testing.Special notes for your reviewer:
fake_image_file
fixture to test both upload and download quickly.Additional documentation or context
Positive Tests
v1.2.2
w/-k test_1_image
(build harvester-runtests/40)v1.2.2
w/-k test_0 or test_1
(build harvester-runtests/41)Negtive Tests
v1.2.1
w/-k test_0 or test_1_image
(local build, can catch fail)