Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TestImageWithStorageNetwork #1395

Conversation

albinsun
Copy link
Contributor

@albinsun albinsun commented Jul 18, 2024

Which issue(s) this PR fixes:

Issue #1083

What this PR does / why we need it:

  1. Add test_1_images.py::TestImageWithStorageNetwork to test image operations within storage-network context, includes:
    • create_image_by_file
    • download_image
    • delete_image
  2. Set raise_on_status=False on session retry_strategy to let requests return 5XX response instead of Max retries exceeded ... error for handy testing.

Special notes for your reviewer:

  1. Use small size fake_image_file fixture to test both upload and download quickly.

Additional documentation or context

Positive Tests

  • v1.2.2 w/ -k test_1_image (build harvester-runtests/40)
    image
  • v1.2.2 w/ -k test_0 or test_1 (build harvester-runtests/41)
    image

Negtive Tests

  • v1.2.1 w/ -k test_0 or test_1_image (local build, can catch fail)
    image

@albinsun albinsun force-pushed the download_image_with_storage_network_enabled branch 3 times, most recently from 306dd48 to e12238e Compare July 19, 2024 04:31
@albinsun albinsun force-pushed the download_image_with_storage_network_enabled branch from e12238e to 3d005fd Compare July 19, 2024 10:15
@albinsun albinsun marked this pull request as ready for review July 19, 2024 14:36
@khushboo-rancher khushboo-rancher merged commit e1fbcfd into harvester:main Jul 22, 2024
3 checks passed
@albinsun albinsun deleted the download_image_with_storage_network_enabled branch July 23, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants