Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: implement kubeconfig-default-token-ttl-minutes api setting tests #1409

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

irishgordo
Copy link
Contributor

Which issue(s) this PR fixes:

Issue: #1392
Resolves: test/implement-1392
See also: harvester/harvester#6011

What this PR does / why we need it:

  • base cases for kubeconfig-default-token-ttl-minutes setting in api (positive & negative)
  • manager enhancement
  • model enhancement

Special notes for your reviewer:

  • N/A

Additional documentation or context

  • does baseline test of updating the setting from default value of 0
  • only applicable with Harvester versions greater than or equal to v1.3.1 (currently)

@irishgordo
Copy link
Contributor Author

Prior to v1.4.0-Dev, test_invalid_kubeconfig_ttl_min will fail, as it was a bug in v1.3.1...

@irishgordo irishgordo marked this pull request as ready for review July 30, 2024 01:31
@irishgordo irishgordo changed the title test: Implement 1392 API Settings Test test: implement kubeconfig-default-token-ttl-minutes api setting tests Jul 30, 2024
@irishgordo irishgordo force-pushed the test/implement-1392 branch from 4b4b6ba to af23c12 Compare July 30, 2024 01:34
harvester_e2e_tests/apis/test_settings.py Outdated Show resolved Hide resolved
harvester_e2e_tests/apis/test_settings.py Outdated Show resolved Hide resolved
harvester_e2e_tests/apis/test_settings.py Show resolved Hide resolved
harvester_e2e_tests/apis/test_settings.py Outdated Show resolved Hide resolved
@irishgordo irishgordo force-pushed the test/implement-1392 branch 2 times, most recently from 2d05939 to c1a21f7 Compare August 6, 2024 00:35
* implements 1392 automation, to test
  kubeconfig-default-token-ttl-minutes setting in Harvester
* introduces baseline tests for positive and negative

Issue: harvester#1392
Resolves: test/implement-1392
See also: harvester/harvester#6011
@irishgordo irishgordo force-pushed the test/implement-1392 branch from c1a21f7 to 24d8a53 Compare August 6, 2024 00:38
Copy link
Contributor

@albinsun albinsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khushboo-rancher khushboo-rancher merged commit e1a7ba8 into harvester:main Aug 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants