Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual] Add and update volume related manual test case for issue 5383 #1413

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

TachunLin
Copy link
Contributor

Which issue(s) this PR fixes:

Harvester issue: harvester/harvester#5383

Test issue: #1412

What this PR does / why we need it:

According to the issue verification steps in comment and compared with existing manual test cases.

Add the new test cases:

  1. A volume can't be attached to another VM
  2. Edit volume to increase size when vm is running

Update the existing test cases

  1. Delete volume that is not attached to a VM
  2. Delete single vm all disks

Additional documentation or context

Tested the preview on the local hugo server

@TachunLin TachunLin requested review from khushboo-rancher and a team July 31, 2024 03:57
1. It should not show up in the Virtual Machine list
1. Disks should be listed/or not in Volumes list as appropriate
1. All volumes attached to the VM should be deleted on the volume psage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the check. Update the typo to volume page.


* Related issues: [#5383](https://github.com/harvester/harvester/issues/5383) [ENHANCEMENT] Refactor harvesterhci.io/owned-by annotation on PVC

## Category:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant colon?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the check. Remove the redundant colon.

Copy link
Contributor

@albinsun albinsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khushboo-rancher khushboo-rancher merged commit 4d4d22b into harvester:main Sep 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants