Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TestVMWithStorageNetwork #1416

Merged

Conversation

albinsun
Copy link
Contributor

@albinsun albinsun commented Jul 31, 2024

Which issue(s) this PR fixes:

Issue #1022 for harvester/harvester#4886

What this PR does / why we need it:

  1. Add TestVMWithStorageNetwork class in integrations/test_3_vm.py, contains 2 TCs:

    • test_enable_storage_network_with_cli_stopped_vm: Main TC
    • test_enable_storage_network_with_api_stopped_vm: Together
  2. Add checker fixtures in fixtures/*.py

  3. Refactor related storage-network integration TCs by checkers

    • test_0_storage_network.py::test_storage_network
    • test_1_images.py::TestImageWithStorageNetwork

Special notes for your reviewer:

  1. For new checkers, I refer to e2e rework: test_vm_actions.py #940 but temporarily w/o callback behavior to just handle explicit polling operations.

Additional documentation or context

Verification

  1. 🟢 harvester-install-and-test#58 using single node v1.3.1

    image

  2. 🟢 Local ipxe-example using 3 nodes v1.2.1

    image

@albinsun albinsun force-pushed the storage_network_with_vm_existence branch 3 times, most recently from 854330d to c507ca8 Compare August 1, 2024 08:51
@albinsun albinsun force-pushed the storage_network_with_vm_existence branch from c507ca8 to 574a634 Compare August 1, 2024 15:49
@albinsun albinsun marked this pull request as ready for review August 1, 2024 17:41
@khushboo-rancher khushboo-rancher merged commit b252910 into harvester:main Aug 1, 2024
3 checks passed
@albinsun albinsun deleted the storage_network_with_vm_existence branch August 2, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants