Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue #1022 for harvester/harvester#4886
What this PR does / why we need it:
Add
TestVMWithStorageNetwork
class inintegrations/test_3_vm.py
, contains 2 TCs:test_enable_storage_network_with_cli_stopped_vm
: Main TCtest_enable_storage_network_with_api_stopped_vm
: TogetherAdd checker fixtures in
fixtures/*.py
GET
) operations (e.g.while endtime > datetime.now():...
) to reduce duplicate code.Refactor related storage-network
integration
TCs by checkerstest_0_storage_network.py::test_storage_network
test_1_images.py::TestImageWithStorageNetwork
Special notes for your reviewer:
Additional documentation or context
Verification
🟢 harvester-install-and-test#58 using single node
v1.3.1
🟢 Local ipxe-example using 3 nodes
v1.2.1