Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some automation issues found in v1.3.2 release testing #1489

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Fix some automation issues found in v1.3.2 release testing #1489

merged 3 commits into from
Sep 10, 2024

Conversation

albinsun
Copy link
Contributor

@albinsun albinsun commented Aug 29, 2024 •
edited
Loading

Which issue(s) this PR fixes:

  1. Issue [TEST] Fix test_1_images.py::TestBackendImages::test_edit_image_in_use #1464
  2. Issue [TEST] Fix test_5_vm_networks_interact.py::TestBackendNetwork #1463

What this PR does / why we need it:

  1. test_1_images.py
    • Correct wrong image id.
  2. test_5_vm_networks_interact.py
    • Fix potential problem caused by unique_name fixture value is overwritten improperly.
    • Teardown volumes

Special notes for your reviewer:

n/a

Additional documentation or context

  • Verification (harvester-runtests/90)
    image

@albinsun albinsun marked this pull request as ready for review August 29, 2024 11:45
@albinsun
Copy link
Contributor Author

albinsun commented Sep 6, 2024 •
edited
Loading

@harvester/qa, please help to review, thx.

irishgordo
irishgordo requested changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@irishgordo irishgordo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just had a small qu for all new # teardown implmentations - otherwise non-blocking, will approve 😄

harvester_e2e_tests/integrations/test_5_vm_networks_interact.py Show resolved Hide resolved
lanfon72
lanfon72 approved these changes Sep 8, 2024
View reviewed changes
Copy link
Member

@lanfon72 lanfon72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khushboo-rancher khushboo-rancher merged commit f5fffa1 into harvester:main Sep 10, 2024
3 of 4 checks passed
@albinsun albinsun deleted the fix_automation_issues branch September 10, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irishgordo irishgordo irishgordo approved these changes

@lanfon72 lanfon72 lanfon72 approved these changes

@TachunLin TachunLin Awaiting requested review from TachunLin

@khushboo-rancher khushboo-rancher Awaiting requested review from khushboo-rancher

@noahgildersleeve noahgildersleeve Awaiting requested review from noahgildersleeve

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@albinsun @lanfon72 @irishgordo @khushboo-rancher