Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_create_with_invalid_url #1503

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

brandboat
Copy link
Member

this is something missed in #1495...

@brandboat brandboat requested review from lanfon72 and bk201 September 4, 2024 07:26
Copy link
Member

@lanfon72 lanfon72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandboat
Copy link
Member Author

Attach screenshot to prove that test_create_with_invalid_url passed this time (test in harvester repo master branch)
截圖 2024-09-04 下午3 39 09

@bk201 bk201 merged commit 586d6a7 into harvester:main Sep 4, 2024
4 checks passed
@brandboat brandboat deleted the fix-test branch September 4, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants