-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated backing images for openSUSE and Ubuntu. #1598
updated backing images for openSUSE and Ubuntu. #1598
Conversation
2faa7aa
to
00dee3f
Compare
Have we run the tests with the changes? |
@@ -22,11 +22,11 @@ sleep-timeout: 3 | |||
# script location to manipulate node power cycle | |||
node-scripts-location: 'scripts/vagrant' | |||
|
|||
opensuse-image-url: https://download.opensuse.org/repositories/Cloud:/Images:/Leap_15.5/images/openSUSE-Leap-15.5.x86_64-NoCloud.qcow2 | |||
opensuse-image-url: https://rsync.opensuse.org/repositories/Cloud%3A/Images%3A/Leap_15.6/images/openSUSE-Leap-15.6.x86_64-NoCloud.qcow2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any difference between rsync.opensuse.org and download.opensuse.org?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked up the most recent image locations and this was what showed up. It shouldn't really matter since they are both running as web servers serving the files. The only downside I see is that if the server changes we'll have to change the URL again. Also this URL doesn't use colons in the URL which should help a bit with compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Need to confirm default version criteria
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Guys, what is the criteria to change default image?
|
It's the default value, which means it will not break anything in Jenkins environment; the fixtures added is required if you run test on the test file directly (although we will not recommend that way) |
@albinsun I was updating Ubuntu due to the ticket requirements. I assume we're going to 24.04 since it's the new LTS release and 22.04 isn't. I know that I just updated several of my environments to 24.04 since 20.04 is going EOL soon |
…re for vm_network_interact to make those pass fixed URL for openSUSE re-added comment
00dee3f
to
24b198b
Compare
Also added in a fixture for vm_network_interact to make those pass
Which issue(s) this PR fixes:
Issue #1570
What this PR does / why we need it:
This updates the OS images for the tests
Special notes for your reviewer:
I also added in a missing fixture I found while validating the images
Additional documentation or context