Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated backing images for openSUSE and Ubuntu. #1598

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

noahgildersleeve
Copy link
Contributor

Also added in a fixture for vm_network_interact to make those pass

Which issue(s) this PR fixes:

Issue #1570

What this PR does / why we need it:

This updates the OS images for the tests

Special notes for your reviewer:

I also added in a missing fixture I found while validating the images

Additional documentation or context

@khushboo-rancher
Copy link
Collaborator

Have we run the tests with the changes?

@@ -22,11 +22,11 @@ sleep-timeout: 3
# script location to manipulate node power cycle
node-scripts-location: 'scripts/vagrant'

opensuse-image-url: https://download.opensuse.org/repositories/Cloud:/Images:/Leap_15.5/images/openSUSE-Leap-15.5.x86_64-NoCloud.qcow2
opensuse-image-url: https://rsync.opensuse.org/repositories/Cloud%3A/Images%3A/Leap_15.6/images/openSUSE-Leap-15.6.x86_64-NoCloud.qcow2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any difference between rsync.opensuse.org and download.opensuse.org?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked up the most recent image locations and this was what showed up. It shouldn't really matter since they are both running as web servers serving the files. The only downside I see is that if the server changes we'll have to change the URL again. Also this URL doesn't use colons in the URL which should help a bit with compatibility.

@albinsun albinsun requested a review from a team October 17, 2024 02:03
albinsun
albinsun previously approved these changes Oct 17, 2024
Copy link
Contributor

@albinsun albinsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albinsun albinsun self-requested a review October 17, 2024 02:23
@albinsun albinsun dismissed their stale review October 17, 2024 02:24

Need to confirm default version criteria

Copy link
Member

@lanfon72 lanfon72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albinsun
Copy link
Contributor

Have we run the tests with the changes?

Guys, what is the criteria to change default image?

opensuse-leap-v15.5 is reaching EOL but ubuntu-v22.04 is not out-of-date yet.
Ref. https://endoflife.date/ubuntu.

@lanfon72
Copy link
Member

It's the default value, which means it will not break anything in Jenkins environment; the fixtures added is required if you run test on the test file directly (although we will not recommend that way)

@noahgildersleeve
Copy link
Contributor Author

Have we run the tests with the changes?

Guys, what is the criteria to change default image?

opensuse-leap-v15.5 is reaching EOL but ubuntu-v22.04 is not out-of-date yet. Ref. https://endoflife.date/ubuntu.

@albinsun I was updating Ubuntu due to the ticket requirements. I assume we're going to 24.04 since it's the new LTS release and 22.04 isn't. I know that I just updated several of my environments to 24.04 since 20.04 is going EOL soon

…re for vm_network_interact to make those pass

fixed URL for openSUSE

re-added comment
@noahgildersleeve noahgildersleeve merged commit 8c3edca into harvester:main Oct 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants