Gracefully setup/teardown network configs and sanitize ISO URL #1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanfon72
reviewed
Jan 21, 2025
| if failed: | ||
| fmt = "Unable to delete VLAN Config {} with error ({}): {}" | ||
| endtime = datetime.now() + timedelta(seconds=wait_timeout) | ||
| while endtime > datetime.now(): |
There was a problem hiding this comment.
we can use
while endtime > datetime.now() and created:and I feel that 3 seconds is too long to perform another delete operation, in UI, user should able to do the deletion in every seconds.
There was a problem hiding this comment.
yes it's more concise, thank you.
Update in latest commit and with 1 sec sleep.
albinsun
force-pushed
the
enhance_cnet_setup_teardown_in_upgrade
branch
from
56f0048 to
9b4b071
Compare
lanfon72
approved these changes
Jan 24, 2025
khushboo-rancher
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
What this PR does / why we need it:
Erro message backward compatibility of expected isourl/checksum in upgrade creation before
v1.4.0screenshot
Fix flaky test
Ref. [TEST] v1.4.1 Release Testing - Automation - Two stage upgrade
Verification
v1.3.2->v1.4.0harvester-upgrade-test#135
v1.4.0->v1.4.1-rc1harvester-upgrade-test#136