Add terraform related test cases #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanfon72
force-pushed
the
terraform
branch
2 times, most recently
from
36b0233 to
9a66ebb
Compare
lanfon72
force-pushed
the
terraform
branch
2 times, most recently
from
36b1da9 to
7b7a406
Compare
|
tested on delete image will always failed which might have some timing issue; and delete clusternetwork will occasionally hit same problem. |
albinsun
approved these changes
Nov 27, 2023
| @pytest.fixture(scope="module") | ||
| def image_resource(unique_name, image_opensuse, tf_resource): | ||
| spec = tf_resource.image_download( | ||
| f"tf_{unique_name}", unique_name, unique_name, image_opensuse.url |
There was a problem hiding this comment.
Consider make prefix "tf_" a variable to reuse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
test_create_imagefor legacytest_create_images_using_terraformtest_delete_imagetest_create_volume_from_imagefor legacytest_create_vol_with_image_terraformTestNetworkingfor legacytest_create_network_using_terraformintegration/test_terraform.pywhcih been replaced withintegration/test_z_terraform.pyfixtures/terraform.pyTerraformHarvesterResourceContext, andTerraformResourceto module scoperawfield forResourceContextTerraformResourceinto version-based:BaseTerraformResourcefor basic functionality, and other inherited classes for resources introduced from specific version.All Harvester terraform resources (image, volume, ssh_key, network, vlanconfig, clusternetwork, storageclass, virtualmachine and cloudinit_secret) has been implemented, but storageclass and VM related test cases are not implemented in this PR.