Add testcase on RKE1 cluster #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albinsun
added
area/backend-automation
albinsun
requested review from
bk201,
lanfon72,
irishgordo,
TachunLin,
khushboo-rancher and
noahgildersleeve
lanfon72
approved these changes
Dec 5, 2023
|
|
||
| def create(self, cluster_id, namespace, name, raw=False): | ||
| url = self.CREATE_fmt.format(cluster_id=cluster_id) + "?action=install" | ||
| data = ChartSpec(cluster_id, namespace, name).to_dict() |
There was a problem hiding this comment.
The Spec is not designed as harvester_api, it would be a bit confusing.
I would suggest that if we are not let Spec as class attribute have more customization, we can simply use create_data instead. (then there would not need the ChartSpec)
There was a problem hiding this comment.
Thanks for the comment.
Already put it into refactoring workitem. Will fix in #960 (comment)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
harvester-cloud-providerchart on RKE1 clusterharvester-csi-driverchart on RKE1 clusterVerification
harvester-runtests#422(RKE1)Note
Failed LB case which has 200 OK status but
<pending>external-ip, which is an known issue harvester/harvester#4689harvester-runtests#422(RKE2)Note
K3s TCs will be add later (#974) together with refactor (#960)