Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The description field is not imported #40

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

votdev
Copy link
Member

@votdev votdev commented Sep 3, 2024

Problem:
The Description field of a compute server is not copied to the imported VM.

Solution:
Extract the Description field from the server data and set the field.cattle.io/description annotation for the imported VM.

Related Issue:
harvester/harvester#6464

Test plan:

  • Create a server in OpenStack and set a description.
  • Import that VM into Harvester.
  • The description should be set for the VM in Harvester.

Note, it seems, not every OpenStack installation is exposing the Description field via their REST API (Nova?) that is called by the vm-import-controllerto fetch the server (VM) metadata.

@votdev votdev marked this pull request as ready for review September 3, 2024 10:23
@votdev votdev force-pushed the issue_6464_server_desc branch from 7b11403 to a61a887 Compare September 3, 2024 10:24
@votdev votdev force-pushed the issue_6464_server_desc branch from a61a887 to 3d423f5 Compare September 3, 2024 14:57
@votdev votdev requested a review from starbops September 9, 2024 07:44
@votdev votdev force-pushed the issue_6464_server_desc branch 2 times, most recently from 01822eb to ea06703 Compare September 23, 2024 09:57
Copy link
Collaborator

@ibrokethecloud ibrokethecloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks.

@votdev votdev force-pushed the issue_6464_server_desc branch from ea06703 to ca86c71 Compare October 7, 2024 05:40
Copy link
Member

@starbops starbops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@votdev votdev merged commit 0eff95e into harvester:main Oct 7, 2024
4 checks passed
@votdev votdev deleted the issue_6464_server_desc branch October 7, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants